From: huanwen ren Date: Tue, 27 Dec 2016 10:54:45 +0000 (+0000) Subject: mon/OSDMonitor: fixup sortbitwise flag warning X-Git-Tag: v11.2.0~23 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f023e97973b03b842ae936da7f7b9f53f91d83d8;p=ceph.git mon/OSDMonitor: fixup sortbitwise flag warning "ceph -s" does not report warning when using command "ceph osd unset sortbitwise" to drop sortbitwise flag. we should use "osdmap.get_up_osd_features() & CEPH_FEATURE_OSD_BITWISE_HOBJ_SORT" instead of "(osdmap.get_features(CEPH_ENTITY_TYPE_OSD, NULL) & CEPH_FEATURE_OSD_BITWISE_HOBJ_SORT)", because osdmap.get_features only get local "features" Signed-off-by: huanwen ren (cherry picked from commit c25ee187e28724846d0011cd8145e16956d3636e) --- diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc index 861cb6b6060e..22732e2ef265 100644 --- a/src/mon/OSDMonitor.cc +++ b/src/mon/OSDMonitor.cc @@ -3084,7 +3084,7 @@ void OSDMonitor::get_health(list >& summary, // Not using 'sortbitwise' and should be? if (!osdmap.test_flag(CEPH_OSDMAP_SORTBITWISE) && - (osdmap.get_features(CEPH_ENTITY_TYPE_OSD, NULL) & + (osdmap.get_up_osd_features() & CEPH_FEATURE_OSD_BITWISE_HOBJ_SORT)) { ostringstream ss; ss << "no legacy OSD present but 'sortbitwise' flag is not set";