From: Yehuda Sadeh <yehuda@redhat.com>
Date: Tue, 21 Jan 2020 21:04:16 +0000 (-0800)
Subject: rgw: remove return std::move()
X-Git-Tag: v15.1.0~22^2~14
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f0ecbc3a234fae77ed3cd1aae28d92337b3f3338;p=ceph-ci.git

rgw: remove return std::move()

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
---

diff --git a/src/rgw/rgw_admin.cc b/src/rgw/rgw_admin.cc
index 2ec0648e6b4..11c66c10a4f 100644
--- a/src/rgw/rgw_admin.cc
+++ b/src/rgw/rgw_admin.cc
@@ -2361,7 +2361,7 @@ static std::vector<string> convert_bucket_set_to_str_vec(const std::set<rgw_buck
   for (auto& b : bs) {
     result.push_back(b.get_key());
   }
-  return std::move(result);
+  return result;
 }
 
 static void get_hint_entities(const std::set<rgw_zone_id>& zones, const std::set<rgw_bucket>& buckets,
diff --git a/src/rgw/rgw_bucket_sync.cc b/src/rgw/rgw_bucket_sync.cc
index c120991af25..3474142322b 100644
--- a/src/rgw/rgw_bucket_sync.cc
+++ b/src/rgw/rgw_bucket_sync.cc
@@ -47,7 +47,7 @@ static std::vector<rgw_sync_bucket_pipe> filter_relevant_pipes(const std::vector
     }
   }
 
-  return std::move(relevant_pipes);
+  return relevant_pipes;
 }
 
 static bool is_wildcard_bucket(const rgw_bucket& bucket)
@@ -229,7 +229,7 @@ vector<rgw_sync_bucket_pipe> rgw_sync_group_pipe_map::find_source_pipes(const rg
       result.push_back(pipe);
     }
   }
-  return std::move(result);
+  return result;
 }
 
 /*
@@ -250,7 +250,7 @@ vector<rgw_sync_bucket_pipe> rgw_sync_group_pipe_map::find_dest_pipes(std::optio
     }
   }
 
-  return std::move(result);
+  return result;
 }
 
 /*
@@ -839,7 +839,7 @@ multimap<rgw_zone_id, rgw_sync_bucket_pipe> RGWBucketSyncPolicyHandler::get_all_
     m.insert(make_pair(*pipe.source.zone, pipe));
   }
 
-  return std::move(m);
+  return m;
 }
 
 multimap<rgw_zone_id, rgw_sync_bucket_pipe> RGWBucketSyncPolicyHandler::get_all_dests() const
diff --git a/src/rgw/rgw_rest_s3.cc b/src/rgw/rgw_rest_s3.cc
index c2f7c298a01..def86793e02 100644
--- a/src/rgw/rgw_rest_s3.cc
+++ b/src/rgw/rgw_rest_s3.cc
@@ -853,7 +853,7 @@ struct ReplicationConfiguration {
         }
       }
 
-      return std::move(ids);
+      return ids;
     }
 
     vector<string> get_zone_names_from_ids(rgw::sal::RGWRadosStore *store,
@@ -867,7 +867,7 @@ struct ReplicationConfiguration {
         }
       }
 
-      return std::move(names);
+      return names;
     }
 
     std::optional<DeleteMarkerReplication> delete_marker_replication;
diff --git a/src/rgw/rgw_sync_policy.cc b/src/rgw/rgw_sync_policy.cc
index d04f632d397..4bd7fbdadab 100644
--- a/src/rgw/rgw_sync_policy.cc
+++ b/src/rgw/rgw_sync_policy.cc
@@ -207,7 +207,7 @@ std::vector<rgw_sync_bucket_entity> rgw_sync_bucket_entities::expand() const
     e.all_zones = true;
     e.bucket = b;
     result.push_back(e);
-    return std::move(result);
+    return result;
   }
 
   if (!zones) {