From: Kefu Chai <kchai@redhat.com>
Date: Tue, 29 Jan 2019 09:18:21 +0000 (+0800)
Subject: osd/HitSet: mark copy ctor of HitSet::Params noexcept
X-Git-Tag: v14.1.0~263^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f14f913fbfcd66526037ac8c5d94d88da05be3b6;p=ceph.git

osd/HitSet: mark copy ctor of HitSet::Params noexcept

to be returned using seastar::future<...> the value type should satisfy
std::is_nothrow_constructible<T>.

with this change, pg_pool_t will be nothrow_constructible. and hence
can be returned using seastar::future<pg_pool_t>. otherwise
std::is_nothrow_constructible<pg_pool_t>::value would be false.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/osd/HitSet.cc b/src/osd/HitSet.cc
index 227a738769b6..653c4448d38a 100644
--- a/src/osd/HitSet.cc
+++ b/src/osd/HitSet.cc
@@ -107,7 +107,7 @@ void HitSet::generate_test_instances(list<HitSet*>& o)
   o.back()->insert(hobject_t("qwer", "", CEPH_NOSNAP, 456, 1, ""));
 }
 
-HitSet::Params::Params(const Params& o)
+HitSet::Params::Params(const Params& o) noexcept
 {
   if (o.get_type() != TYPE_NONE) {
     create_impl(o.get_type());
diff --git a/src/osd/HitSet.h b/src/osd/HitSet.h
index 943f40647141..7e50fd930adf 100644
--- a/src/osd/HitSet.h
+++ b/src/osd/HitSet.h
@@ -104,7 +104,7 @@ public:
       return TYPE_NONE;
     }
 
-    Params(const Params& o);
+    Params(const Params& o) noexcept;
     const Params& operator=(const Params& o);
 
     void encode(bufferlist &bl) const;