From: Sage Weil <sage@redhat.com>
Date: Mon, 28 May 2018 13:11:09 +0000 (-0500)
Subject: unittest_addrs: check parse() return value too
X-Git-Tag: v14.0.1~1259^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f1aba7233e56b4d9f9f859159be33e880b15d3e3;p=ceph.git

unittest_addrs: check parse() return value too

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/test/test_addrs.cc b/src/test/test_addrs.cc
index 24db6cdd2fa8..e96084576e00 100644
--- a/src/test/test_addrs.cc
+++ b/src/test/test_addrs.cc
@@ -254,13 +254,14 @@ TEST(entity_addrvec_t, parse)
   for (auto v : { addr_checks, addr_checks2, addrvec_parse_checks }) {
     for (unsigned i = 0; v[i][0]; ++i) {
       const char *end = "";
-      addrvec.parse(v[i][0], &end);
+      bool ret = addrvec.parse(v[i][0], &end);
       string out = stringify(addrvec);
       string left = end;
       cout << "'" << v[i][0] << "' -> '" << out << "' + '" << left << "'"
 	   << std::endl;
       ASSERT_EQ(out, v[i][1]);
       ASSERT_EQ(left, v[i][2]);
+      ASSERT_TRUE(out.empty() || ret);
     }
   }
 }