From: John Spray Date: Mon, 3 Oct 2016 06:40:12 +0000 (+0100) Subject: messages: fix MMDSBeacon constructor X-Git-Tag: v11.1.0~691^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f1fb667dfd21cd241f4f45ce9ef3f8393d114c60;p=ceph.git messages: fix MMDSBeacon constructor This was leaving garbage in some fields during decode when decoding messages with an older version. Fixes: http://tracker.ceph.com/issues/17466 Signed-off-by: John Spray --- diff --git a/src/messages/MMDSBeacon.h b/src/messages/MMDSBeacon.h index d3840a1c4960..a67ba121943d 100644 --- a/src/messages/MMDSBeacon.h +++ b/src/messages/MMDSBeacon.h @@ -148,7 +148,12 @@ class MMDSBeacon : public PaxosServiceMessage { uint64_t mds_features; public: - MMDSBeacon() : PaxosServiceMessage(MSG_MDS_BEACON, 0, HEAD_VERSION, COMPAT_VERSION) { } + MMDSBeacon() + : PaxosServiceMessage(MSG_MDS_BEACON, 0, HEAD_VERSION, COMPAT_VERSION), + global_id(0), state(MDSMap::STATE_NULL), standby_for_rank(MDS_RANK_NONE), + standby_for_fscid(FS_CLUSTER_ID_NONE), standby_replay(false), + mds_features(0) + { } MMDSBeacon(const uuid_d &f, mds_gid_t g, string& n, epoch_t les, MDSMap::DaemonState st, version_t se, uint64_t feat) : PaxosServiceMessage(MSG_MDS_BEACON, les, HEAD_VERSION, COMPAT_VERSION), fsid(f), global_id(g), name(n), state(st), seq(se),