From: Matan Breizman <mbreizma@redhat.com>
Date: Sun, 26 Nov 2023 14:02:41 +0000 (+0000)
Subject: tools/ceph_objectstore_tool: action_on_all_objects_in_pg to skip pgmeta
X-Git-Tag: v16.2.15~56^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f278c9612f46ff7c394a68851a3352aa14496e2b;p=ceph.git

tools/ceph_objectstore_tool: action_on_all_objects_in_pg to skip pgmeta

See "Error getting attr on" after creating an empty pool:

```
$ ceph-objectstore-tool --data-path ./dev/osd0 --op list
Error getting attr on : 2.0_head,#2:00000000::::head#, (61) No data available
["2.0",{"oid":"","key":"","snapid":-2,"hash":0,"max":0,"pool":2,"namespace":"","max":0}]
```

_action_on_all_objects_in_pg() should skip getting the (non-existing) attributes of pgmeta hobjects.

Note: pgmeta_oid is created at the PG's constructor and is written to disk in init_pg_ondisk()
      without any OI_ATTR.

Fixes: https://tracker.ceph.com/issues/63640

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit 6b0a9a580f3376a5db208674a24e4599500b712f)
---

diff --git a/src/tools/ceph_objectstore_tool.cc b/src/tools/ceph_objectstore_tool.cc
index 590b4a344cba..6593364fdd9a 100644
--- a/src/tools/ceph_objectstore_tool.cc
+++ b/src/tools/ceph_objectstore_tool.cc
@@ -107,7 +107,7 @@ int _action_on_all_objects_in_pg(ObjectStore *store, coll_t coll, action_on_obje
       if (obj->is_pgmeta())
 	continue;
       object_info_t oi;
-      if (coll != coll_t::meta()) {
+      if (coll != coll_t::meta() && !obj->is_pgmeta()) {
         bufferlist attr;
         r = store->getattr(ch, *obj, OI_ATTR, attr);
         if (r < 0) {