From: Guillaume Abrioux <gabrioux@redhat.com>
Date: Wed, 29 Jun 2022 06:59:55 +0000 (+0200)
Subject: backup-and-restore: fix check on 'target_node' variable
X-Git-Tag: v6.0.28~30
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f28002713f43ba030a47306d6d2a81f5a0e81494;p=ceph-ansible.git

backup-and-restore: fix check on 'target_node' variable

If the user doesn't pass a valid name (present in the inventory)
the playbook will fail like following:

```
fatal: [localhost -> {{ target_node }}]: FAILED! =>
  msg: |-
    The task includes an option with an undefined variable. The error was: "hostvars['10.70.46.40']" is undefined
```

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2051640

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit b18a1aa3cafa235dfa4f564d6574318ee539f961)
---

diff --git a/infrastructure-playbooks/backup-and-restore-ceph-files.yml b/infrastructure-playbooks/backup-and-restore-ceph-files.yml
index a01d0e88a..2913310ce 100644
--- a/infrastructure-playbooks/backup-and-restore-ceph-files.yml
+++ b/infrastructure-playbooks/backup-and-restore-ceph-files.yml
@@ -28,7 +28,9 @@
         msg: >
           "You must pass the node name: -e target_node=<inventory_name>.
           The name must match what is set in your inventory."
-      when: target_node is not defined
+      when:
+        - target_node is not defined
+          or target_node not in groups.get('all', [])
 
     - name: exit playbook, if user did not set the backup directory
       fail: