From: Matan Breizman <mbreizma@redhat.com>
Date: Mon, 4 Aug 2025 08:23:45 +0000 (+0000)
Subject: crimson/os/seastore/cache: remove Cache::base_ertr and iertr
X-Git-Tag: testing/wip-vshankar-testing-20250813.085004-debug~14^2~11
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=f36dfd73143c4505614ee2cc042313e69bfe1a56;p=ceph-ci.git

crimson/os/seastore/cache: remove Cache::base_ertr and iertr

Use the common declarations instead

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
---

diff --git a/src/crimson/os/seastore/cache.h b/src/crimson/os/seastore/cache.h
index 332a5ebecba..3dc6dfc7099 100644
--- a/src/crimson/os/seastore/cache.h
+++ b/src/crimson/os/seastore/cache.h
@@ -18,6 +18,7 @@
 #include "crimson/os/seastore/seastore_types.h"
 #include "crimson/os/seastore/segment_manager.h"
 #include "crimson/os/seastore/transaction.h"
+#include "crimson/os/seastore/transaction_interruptor.h"
 #include "crimson/os/seastore/linked_tree_node.h"
 #include "crimson/os/seastore/extent_pinboard.h"
 
@@ -104,10 +105,6 @@ class SegmentProvider;
  */
 class Cache : public ExtentTransViewRetriever {
 public:
-  using base_ertr = crimson::errorator<
-    crimson::ct_error::input_output_error>;
-  using base_iertr = trans_iertr<base_ertr>;
-
   Cache(ExtentPlacementManager &epm);
   ~Cache();
 
diff --git a/src/crimson/os/seastore/lba/btree_lba_manager.cc b/src/crimson/os/seastore/lba/btree_lba_manager.cc
index 051bc1a9275..fe5d500c08d 100644
--- a/src/crimson/os/seastore/lba/btree_lba_manager.cc
+++ b/src/crimson/os/seastore/lba/btree_lba_manager.cc
@@ -713,7 +713,7 @@ static bool is_lba_node(const CachedExtent &e)
   return is_lba_node(e.get_type());
 }
 
-BtreeLBAManager::base_iertr::template future<>
+base_iertr::template future<>
 _init_cached_extent(
   op_context_t c,
   const CachedExtentRef &e,
diff --git a/src/crimson/os/seastore/lba/lba_btree_node.h b/src/crimson/os/seastore/lba/lba_btree_node.h
index b0ca21ae98b..911592a6159 100644
--- a/src/crimson/os/seastore/lba/lba_btree_node.h
+++ b/src/crimson/os/seastore/lba/lba_btree_node.h
@@ -26,7 +26,6 @@ class LogicalChildNode;
 
 namespace crimson::os::seastore::lba {
 
-using base_iertr = Cache::base_iertr;
 using LBANode = FixedKVNode<laddr_t>;
 
 class BtreeLBAMapping;
diff --git a/src/crimson/os/seastore/lba_manager.h b/src/crimson/os/seastore/lba_manager.h
index b4cbc44518d..e6567b05904 100644
--- a/src/crimson/os/seastore/lba_manager.h
+++ b/src/crimson/os/seastore/lba_manager.h
@@ -29,8 +29,6 @@ namespace crimson::os::seastore {
  */
 class LBAManager {
 public:
-  using base_iertr = Cache::base_iertr;
-
   using mkfs_iertr = base_iertr;
   using mkfs_ret = mkfs_iertr::future<>;
   virtual mkfs_ret mkfs(