From: Anna Schumaker <anna.schumaker@oracle.com>
Date: Fri, 25 Apr 2025 15:24:52 +0000 (-0400)
Subject: generic/033: Don't call 'fzero' with the KEEP_SIZE flag
X-Git-Tag: v2025.04.27~7
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f3cbd32a49f57bfbc2b7a41a44195bd153a528ad;p=xfstests-dev.git

generic/033: Don't call 'fzero' with the KEEP_SIZE flag

None of the fzero calls in this test end up writing past the end of the
file, so this flag is unnecessary and can cause the test to fail on
filesystems that don't implement FALLOC_FL_KEEP_SIZE.

Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Zorro Lang <zlang@kernel.org>
---

diff --git a/tests/generic/033 b/tests/generic/033
index a9a9ff5a..b7df56b8 100755
--- a/tests/generic/033
+++ b/tests/generic/033
@@ -37,12 +37,12 @@ $XFS_IO_PROG -f -c "pwrite 0 $bytes" $file >> $seqres.full 2>&1
 # delalloc blocks and convert the ranges to unwritten.
 endoff=$((bytes - 4096))
 for i in $(seq 0 8192 $endoff); do
-	$XFS_IO_PROG -c "fzero -k $i 4k" $file >> $seqres.full 2>&1
+	$XFS_IO_PROG -c "fzero $i 4k" $file >> $seqres.full 2>&1
 done
 
 # now zero the opposite set to remove remaining delalloc extents
 for i in $(seq 4096 8192 $endoff); do
-	$XFS_IO_PROG -c "fzero -k $i 4k" $file >> $seqres.full 2>&1
+	$XFS_IO_PROG -c "fzero $i 4k" $file >> $seqres.full 2>&1
 done
 
 _scratch_cycle_mount