From: Matan Breizman Date: Mon, 4 Aug 2025 10:48:54 +0000 (+0000) Subject: crimson/os/seastore/transaction: Cleanup journal_seq_t users X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=f42e87b43dc69150fc5914aa370b1211add544fe;p=ceph.git crimson/os/seastore/transaction: Cleanup journal_seq_t users Seems like to logic is moved here: ``` last_commit = start_seq; apply_backref_byseq(t.move_backref_entries(), start_seq); commit_backref_entries(std::move(backref_entries), start_seq); ``` Signed-off-by: Matan Breizman --- diff --git a/src/crimson/os/seastore/cache.h b/src/crimson/os/seastore/cache.h index 3dc6dfc7099c8..7d8655e208b17 100644 --- a/src/crimson/os/seastore/cache.h +++ b/src/crimson/os/seastore/cache.h @@ -124,7 +124,6 @@ public: get_dummy_ordering_handle(), is_weak, src, - last_commit, [this](Transaction& t) { return on_transaction_destruct(t); }, @@ -144,7 +143,7 @@ public: SUBDEBUGT(seastore_t, "reset", t); ++(get_by_src(stats.trans_created_by_src, t.get_src())); } - t.reset_preserve_handle(last_commit); + t.reset_preserve_handle(); } /// Declare ref retired in t diff --git a/src/crimson/os/seastore/transaction.h b/src/crimson/os/seastore/transaction.h index 452f275797839..15b8e2b26a871 100644 --- a/src/crimson/os/seastore/transaction.h +++ b/src/crimson/os/seastore/transaction.h @@ -448,7 +448,6 @@ public: OrderingHandle &&handle, bool weak, src_t src, - journal_seq_t initiated_after, on_destruct_func_t&& f, transaction_id_t trans_id, cache_hint_t cache_hint @@ -477,7 +476,7 @@ public: friend class crimson::os::seastore::SeaStore; friend class TransactionConflictCondition; - void reset_preserve_handle(journal_seq_t initiated_after) { + void reset_preserve_handle() { root.reset(); offset = 0; delayed_temp_offset = 0; @@ -858,7 +857,6 @@ inline TransactionRef make_test_transaction() { get_dummy_ordering_handle(), false, Transaction::src_t::MUTATE, - JOURNAL_SEQ_NULL, [](Transaction&) {}, ++next_id, CACHE_HINT_TOUCH