From: Naman Munet <naman.munet@ibm.com>
Date: Wed, 19 Mar 2025 09:20:25 +0000 (+0530)
Subject: mgr/dashboard: Not able to edit user display/full name in user form
X-Git-Tag: testing/wip-pdonnell-testing-20250324.181635-debug~23^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=f4c74f50fa6596f76c2d74ee25fa8ef9ca978161;p=ceph-ci.git

mgr/dashboard: Not able to edit user display/full name in user form

Fixes: https://tracker.ceph.com/issues/70554

Signed-off-by: Naman Munet <naman.munet@ibm.com>
---

diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/users.po.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/users.po.ts
index 6a931faf17b..5b3be4c4101 100644
--- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/users.po.ts
+++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/users.po.ts
@@ -37,7 +37,7 @@ export class UsersPageHelper extends PageHelper {
     this.navigateEdit(name, false, true, null);
 
     // Change the full name field
-    cy.get('input#display_name').click().clear({ force: true }).type(new_fullname, { force: true });
+    cy.get('input#display_name').click().clear().type(new_fullname);
 
     // Change the email field
     cy.get('#email').click().clear().type(new_email);
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.html
index f63f028c5c6..88635763117 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.html
@@ -80,8 +80,7 @@
                formControlName="display_name"
                name="display_name"
                id="display_name"
-               [invalid]="userForm.controls.display_name.invalid && (userForm.controls.display_name.dirty)"
-               [readonly]="editing"/>
+               [invalid]="userForm.showError('display_name', formDir)"/>
       </cds-text-label>
       <ng-template #displayNameError>
         <span class="invalid-feedback"