From: Radosław Zarzyński Date: Tue, 5 Sep 2023 13:21:21 +0000 (+0200) Subject: crimson: drop store from ECBackend to not shadow PGBackend::store X-Git-Tag: v19.3.0~190^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f4e2c3351f6d871ffe38c66e95ac99688f1d28c6;p=ceph.git crimson: drop store from ECBackend to not shadow PGBackend::store This problem was leading to crashes like this one: ``` ../src/crimson/os/futurized_store.h:113:41: runtime error: member access within misaligned address 0xbebebebebebebebe for type 'struct Shard', which requires 8 byte alignment 0xbebebebebebebebe: note: pointer points here --Type for more, q to quit, c to continue without paging-- Thread 1 "crimson-osd" received signal SIGSEGV, Segmentation fault. 0x000055558e7a1dca in crimson::os::FuturizedStore::Shard::do_transaction (txn=..., ch=..., this=0xbebebebebebebebe) at ../src/crimson/os/futurized_store.h:113 113 return do_transaction_no_callbacks( (gdb) bt ``` Signed-off-by: Radosław Zarzyński --- diff --git a/src/crimson/osd/ec_backend.h b/src/crimson/osd/ec_backend.h index 3dbcc4def2e0..56fbb4454231 100644 --- a/src/crimson/osd/ec_backend.h +++ b/src/crimson/osd/ec_backend.h @@ -33,7 +33,6 @@ private: epoch_t min_epoch, epoch_t max_epoch, std::vector&& log_entries) final; CollectionRef coll; - crimson::os::FuturizedStore::Shard* store; seastar::future<> request_committed(const osd_reqid_t& reqid, const eversion_t& version) final { return seastar::now();