From: Yingxin Cheng <yingxin.cheng@intel.com>
Date: Fri, 24 Dec 2021 08:14:29 +0000 (+0800)
Subject: crimson/osd: allow seastar application to print its helps
X-Git-Tag: v17.1.0~163^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f508a45b95353e008d2c2b19a6371ed51967c493;p=ceph.git

crimson/osd: allow seastar application to print its helps

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
---

diff --git a/src/crimson/osd/main.cc b/src/crimson/osd/main.cc
index d3eab632bda74..72f46d8cafd16 100644
--- a/src/crimson/osd/main.cc
+++ b/src/crimson/osd/main.cc
@@ -215,10 +215,9 @@ int main(int argc, char* argv[])
      "Prometheus metrics prefix");
 
   auto [ceph_args, app_args] = partition_args(app, argv, argv + argc);
-  if (ceph_argparse_need_usage(ceph_args) &&
-      std::find(app_args.begin(), app_args.end(), "--help") == app_args.end()) {
+  if (ceph_argparse_need_usage(ceph_args) ||
+      ceph_argparse_need_usage(app_args)) {
     usage(argv[0]);
-    return EXIT_SUCCESS;
   }
   override_seastar_opts(app_args);
   std::string cluster_name{"ceph"};