From: Pere Diaz Bou Date: Thu, 16 Dec 2021 14:31:28 +0000 (+0100) Subject: monitoring/grafana: ValueError instead of RuntimeError X-Git-Tag: v16.2.8~6^2~3 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f5a3a8a991693e5344f38034d2ffdcdceeae483b;p=ceph.git monitoring/grafana: ValueError instead of RuntimeError Signed-off-by: Pere Diaz Bou --- diff --git a/monitoring/ceph-mixin/tests_dashboards/util.py b/monitoring/ceph-mixin/tests_dashboards/util.py index e52a36469e2c..f9295704b472 100644 --- a/monitoring/ceph-mixin/tests_dashboards/util.py +++ b/monitoring/ceph-mixin/tests_dashboards/util.py @@ -42,7 +42,6 @@ def add_dashboard_queries(data: Dict[str, Any], dashboard_data: Dict[str, Any], if 'panels' not in dashboard_data: return error = 0 - dashboard_title = dashboard_data['title'] for panel in dashboard_data['panels']: if ( 'title' in panel @@ -67,7 +66,7 @@ def add_dashboard_queries(data: Dict[str, Any], dashboard_data: Dict[str, Any], data['queries'][query_id] = {'query': target['expr'], 'path': path} data['stats'][path]['total'] += 1 if error: - raise RuntimeError(f'Missing legend_format in queries, please add a proper value.') + raise ValueError('Missing legend_format in queries, please add a proper value.') def add_dashboard_variables(data: Dict[str, Any], dashboard_data: Dict[str, Any]) -> None: