From: John Spray <john.spray@inktank.com>
Date: Tue, 29 Apr 2014 15:22:51 +0000 (+0100)
Subject: mon: warn in newfs if crash_replay_interval=0
X-Git-Tag: v0.84~164^2~11
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f6d029df802528fe192303640e7a97e6050d99a5;p=ceph.git

mon: warn in newfs if crash_replay_interval=0

This is the setting we would apply to data pools
created automatically, so notify the user if they're
failing to use it for data pools they have created
by hand.

Signed-off-by: John Spray <john.spray@inktank.com>
---

diff --git a/src/mon/MDSMonitor.cc b/src/mon/MDSMonitor.cc
index 2b5e8ac79ca3..5edd14ef9708 100644
--- a/src/mon/MDSMonitor.cc
+++ b/src/mon/MDSMonitor.cc
@@ -1152,6 +1152,14 @@ bool MDSMonitor::prepare_command(MMonCommand *m)
       goto out;
     }
 
+    // Warn if crash_replay_interval is not set on the data pool
+    //  (on creation should have done pools[pool].crash_replay_interval =
+    //  cct->_conf->osd_default_data_pool_replay_window;)
+    pg_pool_t const *data_pool = osdmon->osdmap.get_pg_pool(data);
+    if (data_pool->get_crash_replay_interval() == 0) {
+      ss << "warning: crash_replay_interval not set on data pool '" << data << "', ";
+    }
+    
     string sure;
     cmd_getval(g_ceph_context, cmdmap, "sure", sure);
     if (pending_mdsmap.enabled && sure != "--yes-i-really-mean-it") {