From: Piotr Dałek Date: Wed, 2 Mar 2016 12:22:38 +0000 (+0100) Subject: PGMonitor: unconfuse object count skew message X-Git-Tag: v10.1.0~235^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f792a3f613ed7895f86f6b71ea09f0c23f3bbd50;p=ceph.git PGMonitor: unconfuse object count skew message "Pool has too few pgs" is okay assuming it does not take other pools into account. And since it does, it is confusing in the following scenario: 1. Create two pools, one with small pg count and one with large pg count 2. Put a whole lot of objects in smaller pool, resulting in "too few pgs" warning on that pool, which is expected behavior. 3. Put a whole lot of objects in larger pool, warning goes away. Suddenly smaller pool has plenty of PGs? Current message suggests adding more nodes (or PGs) to pool, when actually it's warning about significantly more objects in that particular pool than in the other pools. Signed-off-by: Piotr Dałek --- diff --git a/src/mon/PGMonitor.cc b/src/mon/PGMonitor.cc index 99e2287cf36..0a5f2277a8d 100644 --- a/src/mon/PGMonitor.cc +++ b/src/mon/PGMonitor.cc @@ -2395,7 +2395,7 @@ void PGMonitor::get_health(list >& summary, if (g_conf->mon_pg_warn_max_object_skew > 0 && ratio > g_conf->mon_pg_warn_max_object_skew) { ostringstream ss; - ss << "pool " << name << " has too few pgs"; + ss << "pool " << name << " has many more objects per pg than average (too few pgs?)"; summary.push_back(make_pair(HEALTH_WARN, ss.str())); if (detail) { ostringstream ss;