From: Nitzan Mordechai Date: Sun, 19 May 2024 07:57:13 +0000 (+0000) Subject: PrimaryLogPG: Keep soid before erase entry X-Git-Tag: testing/wip-vshankar-testing-20240731.064922-debug~14^2 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=f7bc4e454786d2ea02991c592b8491eef2e5200f;p=ceph-ci.git PrimaryLogPG: Keep soid before erase entry valgrind errors show when we are erasing entry and then trying to use it. we need to keep the soid before the erase happen. Fixes: https://tracker.ceph.com/issues/64942 Signed-off-by: Nitzan Mordechai --- diff --git a/src/osd/PrimaryLogPG.cc b/src/osd/PrimaryLogPG.cc index a7e6d90a8fe..b7736310c77 100644 --- a/src/osd/PrimaryLogPG.cc +++ b/src/osd/PrimaryLogPG.cc @@ -466,8 +466,8 @@ void PrimaryLogPG::on_local_recover( if (unreadable_object_entry != waiting_for_unreadable_object.end()) { dout(20) << " kicking unreadable waiters on " << hoid << dendl; requeue_ops(unreadable_object_entry->second); - waiting_for_unreadable_object.erase(unreadable_object_entry); finish_unreadable_object(unreadable_object_entry->first); + waiting_for_unreadable_object.erase(unreadable_object_entry); } } } else {