From: Kefu Chai <k.chai@proxmox.com>
Date: Sun, 29 Mar 2026 11:40:46 +0000 (+0800)
Subject: crimson/osd: remove redundant comments
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f7ffbec8f5c648f7bb15b8fd81fc4e0597b25ab3;p=ceph.git

crimson/osd: remove redundant comments

Remove comments that merely restate what the code already says clearly:
- SeastarOption field comments (option_name, config_key, value_type)
- "Define a list of Seastar options" above seastar_options
- "Function to get the option value as a string" above get_option_value
- "stop()s registered using defer() are called here" in main()

Also fix the trailing space before the semicolon in the value_type
field declaration.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---

diff --git a/src/crimson/osd/main.cc b/src/crimson/osd/main.cc
index a24ace8c4705..174bdc2772a3 100644
--- a/src/crimson/osd/main.cc
+++ b/src/crimson/osd/main.cc
@@ -283,7 +283,6 @@ int main(int argc, const char* argv[])
           should_stop.wait().get();
           INFO("crimson shutting down");
           osd.stop().get();
-          // stop()s registered using defer() are called here
         } catch (...) {
           logger().error("startup failed: {}", std::current_exception());
           return EXIT_FAILURE;
diff --git a/src/crimson/osd/main_config_bootstrap_helpers.cc b/src/crimson/osd/main_config_bootstrap_helpers.cc
index 07e9910dee04..3454b5dbc394 100644
--- a/src/crimson/osd/main_config_bootstrap_helpers.cc
+++ b/src/crimson/osd/main_config_bootstrap_helpers.cc
@@ -86,12 +86,11 @@ seastar::future<> populate_config_from_mon()
 }
 
 struct SeastarOption {
-  std::string option_name;  // Command-line option name
-  std::string config_key;   // Configuration key
-  Option::type_t value_type ;   // Type of configuration value
+  std::string option_name;
+  std::string config_key;
+  Option::type_t value_type;
 };
 
-// Define a list of Seastar options
 const std::vector<SeastarOption> seastar_options = {
   {"--task-quota-ms", "crimson_reactor_task_quota_ms", Option::TYPE_FLOAT},
   {"--io-latency-goal-ms", "crimson_reactor_io_latency_goal_ms", Option::TYPE_FLOAT},
@@ -100,7 +99,6 @@ const std::vector<SeastarOption> seastar_options = {
   {"--reactor-backend", "crimson_reactor_backend", Option::TYPE_STR}
 };
 
-// Function to get the option value as a string
 std::optional<std::string> get_option_value(const SeastarOption& option) {
   switch (option.value_type) {
     case Option::TYPE_FLOAT: {