From: Alexander Indenbaum Date: Wed, 18 Dec 2024 10:05:36 +0000 (+0000) Subject: src/nvmeof/NVMeofGwMonitorClient: remove MDS client, not needed X-Git-Tag: v20.0.0~495^2 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=f80687256d9fcce67fb1c3300f088382f53d79f9;p=ceph.git src/nvmeof/NVMeofGwMonitorClient: remove MDS client, not needed Signed-off-by: Alexander Indenbaum --- diff --git a/src/nvmeof/NVMeofGwMonitorClient.cc b/src/nvmeof/NVMeofGwMonitorClient.cc index ce3328aec5167..1b128055e0890 100644 --- a/src/nvmeof/NVMeofGwMonitorClient.cc +++ b/src/nvmeof/NVMeofGwMonitorClient.cc @@ -42,7 +42,6 @@ NVMeofGwMonitorClient::NVMeofGwMonitorClient(int argc, const char **argv) : monc{g_ceph_context, poolctx}, client_messenger(Messenger::create(g_ceph_context, "async", entity_name_t::CLIENT(-1), "client", getpid())), objecter{g_ceph_context, client_messenger.get(), &monc, poolctx}, - client{client_messenger.get(), &monc, &objecter}, timer(g_ceph_context, beacon_lock), orig_argc(argc), orig_argv(argv) @@ -134,7 +133,6 @@ int NVMeofGwMonitorClient::init() // Initialize Messenger client_messenger->add_dispatcher_tail(this); client_messenger->add_dispatcher_head(&objecter); - client_messenger->add_dispatcher_tail(&client); client_messenger->start(); poolctx.start(2); @@ -190,7 +188,6 @@ int NVMeofGwMonitorClient::init() objecter.init(); objecter.enable_blocklist_events(); objecter.start(); - client.init(); timer.init(); { @@ -302,8 +299,7 @@ void NVMeofGwMonitorClient::shutdown() std::lock_guard bl(beacon_lock); timer.shutdown(); } - // client uses monc and objecter - client.shutdown(); + // Stop asio threads, so leftover events won't call into shut down // monclient/objecter. poolctx.finish(); diff --git a/src/nvmeof/NVMeofGwMonitorClient.h b/src/nvmeof/NVMeofGwMonitorClient.h index 6dd167e4e5802..e01c823afb51a 100644 --- a/src/nvmeof/NVMeofGwMonitorClient.h +++ b/src/nvmeof/NVMeofGwMonitorClient.h @@ -21,7 +21,6 @@ #include "common/Timer.h" #include "common/LogClient.h" -#include "client/Client.h" #include "mon/MonClient.h" #include "osdc/Objecter.h" #include "messages/MNVMeofGwMap.h" @@ -58,7 +57,6 @@ protected: MonClient monc; std::unique_ptr client_messenger; Objecter objecter; - Client client; std::map map; ceph::mutex lock = ceph::make_mutex("NVMeofGw::lock"); // allow beacons to be sent independently of handle_nvmeof_gw_map