From: Neha Ojha <nojha@redhat.com>
Date: Mon, 11 Nov 2019 21:32:15 +0000 (-0800)
Subject: osd/OSDMap.cc: don't output over/underfull messages to lderr
X-Git-Tag: v14.2.8~20^2~18^2~13
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f897ee7e098b9c4b7d6931faef64779b6372de5d;p=ceph.git

osd/OSDMap.cc: don't output over/underfull messages to lderr

There can be cases where overfull and underfull(see example in
https://tracker.ceph.com/issues/42756) will be empty, which is not
necessarily an error. These error messages can end up spamming
the ceph-mgr log.

Fixes: https://tracker.ceph.com/issues/42756
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 3cf28f09a2ebdd922fc5c1d29c65469f8331e741)
---

diff --git a/src/osd/OSDMap.cc b/src/osd/OSDMap.cc
index 5030b0fd33c..a8fa7694ac9 100644
--- a/src/osd/OSDMap.cc
+++ b/src/osd/OSDMap.cc
@@ -4552,7 +4552,7 @@ int OSDMap::calc_pg_upmaps(
         overfull.insert(i->second);
       }
     if (overfull.empty()) {
-      lderr(cct) << __func__ << " failed to build overfull" << dendl;
+      ldout(cct, 20) << __func__ << " failed to build overfull" << dendl;
       break;
     }
 
@@ -4564,7 +4564,7 @@ int OSDMap::calc_pg_upmaps(
         underfull.push_back(i->second);
     }
     if (underfull.empty()) {
-      lderr(cct) << __func__ << " failed to build underfull" << dendl;
+      ldout(cct, 20) << __func__ << " failed to build underfull" << dendl;
       break;
     }