From: Casey Bodley Date: Mon, 31 Jul 2023 23:52:15 +0000 (-0400) Subject: rgw/swift: remove redundant moves of object name X-Git-Tag: v19.0.0~757^2 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=f8ae8d88a3f23f3c9b9ec1ce105a5beec66de48b;p=ceph.git rgw/swift: remove redundant moves of object name resolves a compiler warning: /home/cbodley/ceph/src/rgw/rgw_rest_swift.cc: In member function ‘RGWOp* RGWSwiftWebsiteHandler::get_ws_listing_op()’: /home/cbodley/ceph/src/rgw/rgw_rest_swift.cc:2558:33: warning: redundant move in initialization [-Wredundant-move] 2558 | std::string prefix = std::move(s->object->get_name()); | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ /home/cbodley/ceph/src/rgw/rgw_rest_swift.cc:2558:33: note: remove ‘std::move’ call Signed-off-by: Casey Bodley --- diff --git a/src/rgw/rgw_rest_swift.cc b/src/rgw/rgw_rest_swift.cc index 11e7c647c7d91..353520b52d80f 100644 --- a/src/rgw/rgw_rest_swift.cc +++ b/src/rgw/rgw_rest_swift.cc @@ -1982,7 +1982,7 @@ void RGWFormPost::init(rgw::sal::Driver* const driver, RGWHandler* const dialect_handler) { if (!rgw::sal::Object::empty(s->object)) { - prefix = std::move(s->object->get_name()); + prefix = s->object->get_name(); s->object->set_key(rgw_obj_key()); } @@ -2555,7 +2555,7 @@ RGWOp* RGWSwiftWebsiteHandler::get_ws_listing_op() } }; - std::string prefix = std::move(s->object->get_name()); + std::string prefix = s->object->get_name(); s->object->set_key(rgw_obj_key()); return new RGWWebsiteListing(std::move(prefix));