From: Redouane Kachach <rkachach@redhat.com>
Date: Mon, 17 Oct 2022 09:16:52 +0000 (+0200)
Subject: mgr/prometheus: fix module crash when trying to collect OSDs metrics
X-Git-Tag: v18.1.0~732^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f8e4bcfd5929473e4aabbe20ade7c250234dbd52;p=ceph.git

mgr/prometheus: fix module crash when trying to collect OSDs metrics
Fixes: https://tracker.ceph.com/issues/57876

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
---

diff --git a/src/pybind/mgr/prometheus/module.py b/src/pybind/mgr/prometheus/module.py
index ee79951123d..d45ec584a3d 100644
--- a/src/pybind/mgr/prometheus/module.py
+++ b/src/pybind/mgr/prometheus/module.py
@@ -1072,8 +1072,9 @@ class Module(MgrModule):
         for server in self.list_servers():
             host = cast(str, server.get('hostname', ''))
             for service in cast(List[ServiceInfoT], server.get('services', [])):
-                ret.update({(service['id'], service['type']): (
-                    host, service['ceph_version'], service.get('name', ''))})
+                ret.update({(service['id'], service['type']): (host,
+                                                               service.get('ceph_version', 'unknown'),
+                                                               service.get('name', ''))})
         return ret
 
     @profile_method()