From: Andrew Schoen Date: Tue, 4 Dec 2018 20:23:47 +0000 (-0600) Subject: ceph-volume: batch mixed type scenarios have no need to calulate data size X-Git-Tag: v13.2.7~217^2~22 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f92eda34d6cb41890036a39ce7746454b1a871de;p=ceph.git ceph-volume: batch mixed type scenarios have no need to calulate data size We know with a mixed type scenario the device used for data will be used at 100% capacity. This means we do not need to be explict when asking for the size of the data lvs, which avoids rounding errors with very small device sizes. Signed-off-by: Andrew Schoen (cherry picked from commit 0023961397d19659200eaf420f2789db17a71b34) --- diff --git a/src/ceph-volume/ceph_volume/devices/lvm/strategies/bluestore.py b/src/ceph-volume/ceph_volume/devices/lvm/strategies/bluestore.py index e9a0e268c9b..d0630e768a7 100644 --- a/src/ceph-volume/ceph_volume/devices/lvm/strategies/bluestore.py +++ b/src/ceph-volume/ceph_volume/devices/lvm/strategies/bluestore.py @@ -259,9 +259,8 @@ class MixedType(MixedStrategy): # block.db vg from before for osd in self.computed['osds']: data_path = osd['data']['path'] - data_lv_size = disk.Size(b=osd['data']['size']).gb.as_int() data_vg = data_vgs[data_path] - data_lv_extents = data_vg.sizing(size=data_lv_size)['extents'] + data_lv_extents = data_vg.sizing(parts=1)['extents'] data_lv = lvm.create_lv( 'osd-block', data_vg.name, extents=data_lv_extents, uuid_name=True ) diff --git a/src/ceph-volume/ceph_volume/devices/lvm/strategies/filestore.py b/src/ceph-volume/ceph_volume/devices/lvm/strategies/filestore.py index 59a068f28e1..a642893d4be 100644 --- a/src/ceph-volume/ceph_volume/devices/lvm/strategies/filestore.py +++ b/src/ceph-volume/ceph_volume/devices/lvm/strategies/filestore.py @@ -338,9 +338,8 @@ class MixedType(MixedStrategy): for osd in self.computed['osds']: data_path = osd['data']['path'] - data_lv_size = disk.Size(b=osd['data']['size']).gb.as_int() data_vg = data_vgs[data_path] - data_lv_extents = data_vg.sizing(size=data_lv_size)['extents'] + data_lv_extents = data_vg.sizing(parts=1)['extents'] data_lv = lvm.create_lv( 'osd-data', data_vg.name, extents=data_lv_extents, uuid_name=True )