From: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
Date: Thu, 22 May 2025 08:20:57 +0000 (+0530)
Subject: mon/MgrStatMonitor.cc: do not update score when disabled
X-Git-Tag: v20.1.0~171^2~4
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=f9efe0b17348a7be5f4ebe00a90f5c0e88aabada;p=ceph.git

mon/MgrStatMonitor.cc: do not update score when disabled

This commit adds changes to ensure the availability score
tracking is not updated when the feature is disabled. We
will preserve the score calculated before the feature is
turned off and start updating it again when the feature
is enabled.

Fixes: https://tracker.ceph.com/issues/71494

Signed-off-by: Shraddha Agrawal <shraddhaag@ibm.com>
(cherry picked from commit 017c9b9f4fa0d3286d52b7acb7df912327b1f836)
---

diff --git a/src/mon/MgrStatMonitor.cc b/src/mon/MgrStatMonitor.cc
index e568a491c43..52121a63c05 100644
--- a/src/mon/MgrStatMonitor.cc
+++ b/src/mon/MgrStatMonitor.cc
@@ -69,6 +69,14 @@ void MgrStatMonitor::create_initial()
 void MgrStatMonitor::calc_pool_availability()
 {
   dout(20) << __func__ << dendl;
+
+  // if feature is disabled by user, do not update the uptime 
+  // and downtime, exit early
+  if (!g_conf().get_val<bool>("enable_availability_tracking")) {
+    dout(20) << __func__ << " tracking availability score is disabled" << dendl;
+    return;
+  }
+
   auto pool_avail_end = pool_availability.end();
   for (const auto& i : digest.pool_pg_unavailable_map) {
     const auto& poolid = i.first;
diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc
index 3da45e2fabe..cc1f40a6edb 100644
--- a/src/mon/OSDMonitor.cc
+++ b/src/mon/OSDMonitor.cc
@@ -14412,7 +14412,7 @@ bool OSDMonitor::prepare_command_impl(MonOpRequestRef op,
   } else if (prefix == "osd pool availability-status") {
     if (!g_conf().get_val<bool>("enable_availability_tracking")) {
       ss << "availability tracking is disabled; you can enable it by setting the config option enable_availability_tracking";
-      err = -EPERM;
+      err = -EOPNOTSUPP;
       goto reply_no_propose;
     }
     TextTable tbl;