From: Darrick J. Wong Date: Mon, 21 Jun 2021 18:53:03 +0000 (-0700) Subject: xfs: fix endianness issue in xfs_ag_shrink_space X-Git-Tag: libxfs-5.14-sync_2021-07-02^0 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=fa533e4674bed261153787e2ef00f9281ad2fcdf;p=xfsprogs-dev.git xfs: fix endianness issue in xfs_ag_shrink_space The AGI buffer is in big-endian format, so we must convert the endianness to CPU format to do any comparisons. Fixes: 46141dc891f7 ("xfs: introduce xfs_ag_shrink_space()") Signed-off-by: Darrick J. Wong --- diff --git a/libxfs/xfs_ag.c b/libxfs/xfs_ag.c index cf4d65a3..bb25c304 100644 --- a/libxfs/xfs_ag.c +++ b/libxfs/xfs_ag.c @@ -509,6 +509,7 @@ xfs_ag_shrink_space( struct xfs_buf *agibp, *agfbp; struct xfs_agi *agi; struct xfs_agf *agf; + xfs_agblock_t aglen; int error, err2; ASSERT(agno == mp->m_sb.sb_agcount - 1); @@ -523,14 +524,14 @@ xfs_ag_shrink_space( return error; agf = agfbp->b_addr; + aglen = be32_to_cpu(agi->agi_length); /* some extra paranoid checks before we shrink the ag */ if (XFS_IS_CORRUPT(mp, agf->agf_length != agi->agi_length)) return -EFSCORRUPTED; - if (delta >= agi->agi_length) + if (delta >= aglen) return -EINVAL; - args.fsbno = XFS_AGB_TO_FSB(mp, agno, - be32_to_cpu(agi->agi_length) - delta); + args.fsbno = XFS_AGB_TO_FSB(mp, agno, aglen - delta); /* * Disable perag reservations so it doesn't cause the allocation request