From: Casey Bodley Date: Thu, 20 Jul 2023 13:23:52 +0000 (-0400) Subject: valgrind: remove stale openssl suppressions X-Git-Tag: v18.1.3~2^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=fa5ef29a2b19138fbc8f4ed50e58d9486faee9ff;p=ceph.git valgrind: remove stale openssl suppressions years ago in commit fe97a000990632dbe9734e0d3a96df627f104f7a, the signature of authenticated_decrypt_update_final() changed and this suppression no longer matches its mangled form: - fun:_ZN4ceph6crypto6onwire25AES128GCM_OnWireRxHandler34authenticated_decrypt_update_finalEONS_6buffer7v*4listEj + fun:_ZN4ceph6crypto6onwire25AES128GCM_OnWireRxHandler34authenticated_decrypt_update_finalERNS_6buffer7v15_2_04listE the fact that we didn't notice must mean that we don't need the suppressions anymore Signed-off-by: Casey Bodley (cherry picked from commit d6d9986315481ca13e8823c8e26c03eeac2d1713) --- diff --git a/qa/valgrind.supp b/qa/valgrind.supp index b08942fff6a9..8caedfd8b22f 100644 --- a/qa/valgrind.supp +++ b/qa/valgrind.supp @@ -689,31 +689,3 @@ fun:EVP_DecryptFinal_ex ... } - -# "Conditional jump or move depends on uninitialised value(s)" in OpenSSL -# while using aes-128-gcm with AES-NI enabled. Not observed while running -# with `OPENSSL_ia32cap="~0x200000200000000"`. -{ - uninitialised gcm.Xi in aes-128-gcm with AES-NI for msgr, part 1 - Memcheck:Cond - ... - fun:EVP_DecryptFinal_ex - fun:_ZN4ceph6crypto6onwire25AES128GCM_OnWireRxHandler34authenticated_decrypt_update_finalEONS_6buffer7v*4listEj - fun:_ZN10ProtocolV231handle_read_frame_epilogue_mainEOSt10unique_ptrIN4ceph6buffer7v*8ptr_nodeENS4_8disposerEEi - fun:_ZN10ProtocolV216run_continuationER2CtIS_E - ... - fun:_ZN15AsyncConnection7processEv - fun:_ZN11EventCenter14process_eventsEjPNSt6chrono8durationImSt5ratioILl1ELl1000000000EEEE - ... -} - -{ - uninitialised gcm.Xi in aes-128-gcm with AES-NI for msgr, part 2 - Memcheck:Cond - fun:_ZN4ceph6crypto6onwire25AES128GCM_OnWireRxHandler34authenticated_decrypt_update_finalEONS_6buffer7v*4listEj - fun:_ZN10ProtocolV231handle_read_frame_epilogue_mainEOSt10unique_ptrIN4ceph6buffer7v*8ptr_nodeENS4_8disposerEEi - fun:_ZN10ProtocolV216run_continuationER2CtIS_E - ... - fun:_ZN11EventCenter14process_eventsEjPNSt6chrono8durationImSt5ratioILl1ELl1000000000EEEE - ... -}