From: Adam C. Emerson Date: Fri, 29 Mar 2019 01:07:29 +0000 (-0400) Subject: erasure-code: Update shec to work without using namespace X-Git-Tag: v15.0.0~19^2~45 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=fbc4057e69e308ca636386761621ba7fbfb8828a;p=ceph.git erasure-code: Update shec to work without using namespace Signed-off-by: Adam C. Emerson --- diff --git a/src/erasure-code/shec/ErasureCodePluginShec.cc b/src/erasure-code/shec/ErasureCodePluginShec.cc index b0ecf3f02b1c..3eab48f90edb 100644 --- a/src/erasure-code/shec/ErasureCodePluginShec.cc +++ b/src/erasure-code/shec/ErasureCodePluginShec.cc @@ -31,15 +31,15 @@ #undef dout_prefix #define dout_prefix _prefix(_dout) -static ostream& _prefix(std::ostream* _dout) +static std::ostream& _prefix(std::ostream* _dout) { return *_dout << "ErasureCodePluginShec: "; } int ErasureCodePluginShec::factory(const std::string &directory, - ErasureCodeProfile &profile, - ErasureCodeInterfaceRef *erasure_code, - std::ostream *ss) { + ceph::ErasureCodeProfile &profile, + ceph::ErasureCodeInterfaceRef *erasure_code, + std::ostream *ss) { ErasureCodeShec *interface; if (profile.find("technique") == profile.end()) @@ -61,7 +61,7 @@ int ErasureCodePluginShec::factory(const std::string &directory, delete interface; return r; } - *erasure_code = ErasureCodeInterfaceRef(interface); + *erasure_code = ceph::ErasureCodeInterfaceRef(interface); dout(10) << "ErasureCodePluginShec: factory() completed" << dendl; @@ -72,7 +72,7 @@ const char *__erasure_code_version() { return CEPH_GIT_NICE_VER; } int __erasure_code_init(char *plugin_name, char *directory = (char *)"") { - ErasureCodePluginRegistry &instance = ErasureCodePluginRegistry::instance(); + auto& instance = ceph::ErasureCodePluginRegistry::instance(); int w[] = { 8, 16, 32 }; int r = jerasure_init(3, w); if (r) { diff --git a/src/erasure-code/shec/ErasureCodePluginShec.h b/src/erasure-code/shec/ErasureCodePluginShec.h index 72b59a466b21..b73e49b4635e 100644 --- a/src/erasure-code/shec/ErasureCodePluginShec.h +++ b/src/erasure-code/shec/ErasureCodePluginShec.h @@ -21,14 +21,14 @@ #include "ErasureCodeShecTableCache.h" #include "erasure-code/ErasureCodePlugin.h" -class ErasureCodePluginShec : public ErasureCodePlugin { +class ErasureCodePluginShec : public ceph::ErasureCodePlugin { public: ErasureCodeShecTableCache tcache; int factory(const std::string &directory, - ErasureCodeProfile &profile, - ErasureCodeInterfaceRef *erasure_code, - ostream *ss) override; + ceph::ErasureCodeProfile &profile, + ceph::ErasureCodeInterfaceRef *erasure_code, + std::ostream *ss) override; }; #endif diff --git a/src/erasure-code/shec/ErasureCodeShec.cc b/src/erasure-code/shec/ErasureCodeShec.cc index 75bbe97d38d2..9ec8dcc47c5c 100644 --- a/src/erasure-code/shec/ErasureCodeShec.cc +++ b/src/erasure-code/shec/ErasureCodeShec.cc @@ -18,13 +18,11 @@ * */ -#include -#include -#include -#include +#include +#include +#include +#include #include -using namespace std; - #include "common/debug.h" #include "ErasureCodeShec.h" extern "C" { @@ -40,6 +38,10 @@ extern int* reed_sol_vandermonde_coding_matrix(int k, int m, int w); #undef dout_prefix #define dout_prefix _prefix(_dout) +using namespace std; +using namespace ceph; + + static ostream& _prefix(std::ostream* _dout) { return *_dout << "ErasureCodeShec: "; diff --git a/src/erasure-code/shec/ErasureCodeShec.h b/src/erasure-code/shec/ErasureCodeShec.h index b53eb538ffa3..44a0778854fe 100644 --- a/src/erasure-code/shec/ErasureCodeShec.h +++ b/src/erasure-code/shec/ErasureCodeShec.h @@ -24,7 +24,7 @@ #include "erasure-code/ErasureCode.h" #include "ErasureCodeShecTableCache.h" -class ErasureCodeShec : public ErasureCode { +class ErasureCodeShec : public ceph::ErasureCode { public: enum { @@ -75,24 +75,24 @@ public: const std::set &available_chunks, std::set *minimum); - int minimum_to_decode_with_cost(const set &want_to_read, - const map &available, - set *minimum) override; + int minimum_to_decode_with_cost(const std::set &want_to_read, + const std::map &available, + std::set *minimum) override; - int encode(const set &want_to_encode, - const bufferlist &in, - map *encoded) override; - int encode_chunks(const set &want_to_encode, - map *encoded) override; + int encode(const std::set &want_to_encode, + const ceph::buffer::list &in, + std::map *encoded) override; + int encode_chunks(const std::set &want_to_encode, + std::map *encoded) override; int _decode(const std::set &want_to_read, - const std::map &chunks, - std::map *decoded) override; - int decode_chunks(const set &want_to_read, - const map &chunks, - map *decoded) override; + const std::map &chunks, + std::map *decoded) override; + int decode_chunks(const std::set &want_to_read, + const std::map &chunks, + std::map *decoded) override; - int init(ErasureCodeProfile &profile, ostream *ss) override; + int init(ceph::ErasureCodeProfile &profile, std::ostream *ss) override; virtual void shec_encode(char **data, char **coding, int blocksize) = 0; @@ -109,7 +109,7 @@ public: virtual int* shec_reedsolomon_coding_matrix(int is_single); private: - virtual int parse(const ErasureCodeProfile &profile) = 0; + virtual int parse(const ceph::ErasureCodeProfile &profile) = 0; virtual double shec_calc_recovery_efficiency1(int k, int m1, int m2, int c1, int c2); virtual int shec_make_decoding_matrix(bool prepare, @@ -141,7 +141,7 @@ public: unsigned get_alignment() const override; void prepare() override; private: - int parse(const ErasureCodeProfile &profile) override; + int parse(const ceph::ErasureCodeProfile &profile) override; }; #endif