From: Sebastian Wagner <sebastian.wagner@suse.com>
Date: Thu, 30 Jul 2020 11:38:45 +0000 (+0200)
Subject: mgr/cephadm: Don't run `daemons_post` if _create_daemon fail
X-Git-Tag: v16.1.0~1507^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=fdaa00977e3d9ee3bd1c6f5be69a0e93d6825136;p=ceph.git

mgr/cephadm: Don't run `daemons_post` if _create_daemon fail

We can't run daemon_check_post for the type, if a single daemon failed.
Mainly cause `daemon_check_post` is run by service type.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
---

diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py
index 8ebe570cf8fe..576932c17de4 100644
--- a/src/pybind/mgr/cephadm/module.py
+++ b/src/pybind/mgr/cephadm/module.py
@@ -2128,9 +2128,13 @@ you may want to run:
                         reconfig=True)
                 except OrchestratorError as e:
                     self.events.from_orch_error(e)
+                    if dd.daemon_type in daemons_post:
+                        del daemons_post[dd.daemon_type]
                     # continue...
                 except Exception as e:
                     self.events.for_daemon_from_exception(dd.name(), e)
+                    if dd.daemon_type in daemons_post:
+                        del daemons_post[dd.daemon_type]
                     # continue...
 
         # do daemon post actions