From: Danny Al-Gaaf Date: Wed, 18 Mar 2015 14:03:28 +0000 (+0100) Subject: rgw_rest_user.cc: UserQuotas init vars in ctor init list X-Git-Tag: v9.0.1~128^2~11 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=feb989cdaa7eb9f594717e67f2322b34722ffe78;p=ceph.git rgw_rest_user.cc: UserQuotas init vars in ctor init list Fix for: [src/rgw/rgw_rest_user.cc:631]: (performance) Variable 'bucket_quota' is assigned in constructor body. Consider performing initialization in initialization list. [src/rgw/rgw_rest_user.cc:632]: (performance) Variable 'user_quota' is assigned in constructor body. Consider performing initialization in initialization list. Signed-off-by: Danny Al-Gaaf --- diff --git a/src/rgw/rgw_rest_user.cc b/src/rgw/rgw_rest_user.cc index 8d8485fcc00..cfc274bc409 100644 --- a/src/rgw/rgw_rest_user.cc +++ b/src/rgw/rgw_rest_user.cc @@ -627,10 +627,9 @@ struct UserQuotas { UserQuotas() {} - UserQuotas(RGWUserInfo& info) { - bucket_quota = info.bucket_quota; - user_quota = info.user_quota; - } + UserQuotas(RGWUserInfo& info) : bucket_quota(info.bucket_quota), + user_quota(info.user_quota) {} + void dump(Formatter *f) const { encode_json("bucket_quota", bucket_quota, f); encode_json("user_quota", user_quota, f);