From: Aashish Sharma Date: Wed, 15 Jul 2020 14:33:50 +0000 (+0530) Subject: mgr/dashboard: increase API test coverage in API controllers X-Git-Tag: wip-pdonnell-testing-20200918.022351~587^2~2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ffb76a88ddf350a81ccee1f4fe76dd6dc0e975f5;p=ceph-ci.git mgr/dashboard: increase API test coverage in API controllers Added test cases for the missing endpoints Fixes: https://tracker.ceph.com/issues/45901 Signed-off-by: Aashish Sharma --- diff --git a/qa/tasks/mgr/dashboard/test_cephfs.py b/qa/tasks/mgr/dashboard/test_cephfs.py index 3418ccfda4d..5ee39457aa1 100644 --- a/qa/tasks/mgr/dashboard/test_cephfs.py +++ b/qa/tasks/mgr/dashboard/test_cephfs.py @@ -154,7 +154,6 @@ class CephfsTest(DashboardTestCase): 'max_files': int })) - def test_cephfs_tabs(self): fs_id = self.get_fs_id() data = self._get("/ui-api/cephfs/{}/tabs".format(fs_id)) diff --git a/qa/tasks/mgr/dashboard/test_mgr_module.py b/qa/tasks/mgr/dashboard/test_mgr_module.py index 407871b9bad..266ab2d343f 100644 --- a/qa/tasks/mgr/dashboard/test_mgr_module.py +++ b/qa/tasks/mgr/dashboard/test_mgr_module.py @@ -47,7 +47,6 @@ class MgrModuleTest(MgrModuleTestCase): 'see_also': JList(str) }) - def test_list_disabled_module(self): self._ceph_cmd(['mgr', 'module', 'disable', 'iostat']) self.wait_until_rest_api_accessible() diff --git a/qa/tasks/mgr/dashboard/test_pool.py b/qa/tasks/mgr/dashboard/test_pool.py index 532cc23f001..c8d8195f6f6 100644 --- a/qa/tasks/mgr/dashboard/test_pool.py +++ b/qa/tasks/mgr/dashboard/test_pool.py @@ -157,10 +157,10 @@ class PoolTest(DashboardTestCase): def test_delete_access_permissions(self): self._delete('/api/pool/ddd') self.assertStatus(403) - + def test_pool_configuration(self): pool_name = 'device_health_metrics' - data= self._get('/api/pool/{}/configuration'.format(pool_name)) + data = self._get('/api/pool/{}/configuration'.format(pool_name)) self.assertStatus(200) self.assertSchema(data, JList(JObj({ 'name': str,