From: Deepika Upadhyay <dupadhya@redhat.com>
Date: Wed, 21 Jul 2021 16:03:42 +0000 (+0530)
Subject: cmake: adds BUILD_BYPRODUCT for external build jaegertracing libs
X-Git-Tag: v17.1.0~1325^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ffc37646067ac072b946a9e7a62c64e18e27ab65;p=ceph.git

cmake: adds BUILD_BYPRODUCT for external build jaegertracing libs

* adds BUILD_BYPRODUCT which tells ninja which library will be generated
after the build(needed for dependent build libs)

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
---

diff --git a/cmake/modules/BuildJaeger.cmake b/cmake/modules/BuildJaeger.cmake
index 16e30dd33357..338013335a62 100644
--- a/cmake/modules/BuildJaeger.cmake
+++ b/cmake/modules/BuildJaeger.cmake
@@ -51,7 +51,8 @@ function(build_jaeger)
 			-Dthrift_HOME=${CMAKE_BINARY_DIR}/external
 			-DOpenTracing_HOME=${CMAKE_BINARY_DIR}/external)
 
-  set(dependencies opentracing thrift)
+  # build these libraries along with jaeger
+  set(dependencies opentracing)
   if(NOT WITH_SYSTEM_BOOST)
     list(APPEND dependencies Boost)
   endif()
@@ -78,7 +79,7 @@ function(build_jaeger)
     BINARY_DIR ${Jaeger_BINARY_DIR}
     BUILD_COMMAND ${make_cmd}
     INSTALL_COMMAND ${install_cmd}
-    DEPENDS "${dependencies}"
+    DEPENDS ${dependencies}
     BUILD_BYPRODUCTS ${CMAKE_BINARY_DIR}/external/lib/libjaegertracing.so
     )