From: Rongqi Sun <sunrongqi@huawei.com>
Date: Mon, 5 Aug 2024 08:03:40 +0000 (+0800)
Subject: Revert "reef: rgw/amqp: lock erase and create connection before emplace"
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fheads%2Frevert-58715-wip-67072-reef;p=ceph.git

Revert "reef: rgw/amqp: lock erase and create connection before emplace"
---

diff --git a/src/rgw/rgw_amqp.cc b/src/rgw/rgw_amqp.cc
index f8b826213d29d..3014edd1db09d 100644
--- a/src/rgw/rgw_amqp.cc
+++ b/src/rgw/rgw_amqp.cc
@@ -535,12 +535,9 @@ typedef boost::lockfree::queue<message_wrapper_t*, boost::lockfree::fixed_sized<
           continue;
 
 #define ERASE_AND_CONTINUE(IT,CONTAINER) \
-          { \
-            std::lock_guard lock(connections_lock); \
-            IT=CONTAINER.erase(IT); \
-            --connection_count; \
-            continue; \
-          }
+          IT=CONTAINER.erase(IT); \
+          --connection_count; \
+          continue;
 
 class Manager {
 public:
@@ -886,14 +883,12 @@ public:
     }
     // if error occurred during creation the creation will be retried in the main thread
     ++connection_count;
-    auto conn = std::make_unique<connection_t>(cct, info, verify_ssl, ca_location);
-    if (new_state(conn.get(), tmp_id)) {
-        ldout(cct, 10) << "AMQP connect: new connection is created. Total connections: " << connection_count << dendl;
-    } else {
-        ldout(cct, 1) << "AMQP connect: new connection '" << to_string(tmp_id) << "' is created. but state creation failed (will retry). error: " <<
-            status_to_string(conn->status) << " (" << conn->reply_code << ")"  << dendl;
+    auto conn = connections.emplace(tmp_id, std::make_unique<connection_t>(cct, info, verify_ssl, ca_location)).first->second.get();
+    ldout(cct, 10) << "AMQP connect: new connection is created. Total connections: " << connection_count << dendl;
+    if (!new_state(conn, tmp_id)) {
+      ldout(cct, 1) << "AMQP connect: new connection '" << to_string(tmp_id) << "' is created. but state creation failed (will retry). error: " <<
+        status_to_string(conn->status) << " (" << conn->reply_code << ")"  << dendl;
     }
-    connections.emplace(tmp_id, std::move(conn));
     id = std::move(tmp_id);
     return true;
   }