From: Yehuda Sadeh <yehuda@redhat.com>
Date: Fri, 29 Jul 2016 23:07:01 +0000 (-0700)
Subject: test_rgw_bencode: null terminate strings before checking
X-Git-Tag: ses5-milestone5~245^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F10510%2Fhead;p=ceph.git

test_rgw_bencode: null terminate strings before checking

Fixes: http://tracker.ceph.com/issues/16861

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
---

diff --git a/src/test/rgw/test_rgw_bencode.cc b/src/test/rgw/test_rgw_bencode.cc
index 177d72f327e0..66fa92a8a179 100644
--- a/src/test/rgw/test_rgw_bencode.cc
+++ b/src/test/rgw/test_rgw_bencode.cc
@@ -13,7 +13,9 @@ TEST(Bencode, String)
   decode.bencode("bar", bl);
   decode.bencode("baz", bl);
 
-  ASSERT_STREQ("3:foo3:bar3:baz", bl.c_str());
+  string s(bl.c_str(), bl.length());
+
+  ASSERT_STREQ("3:foo3:bar3:baz", s.c_str());
 }
 
 TEST(Bencode, Integers)
@@ -25,7 +27,9 @@ TEST(Bencode, Integers)
   decode.bencode(-3, bl);
   decode.bencode(7, bl);
 
-  ASSERT_STREQ("i0ei-3ei7e", bl.c_str());
+  string s(bl.c_str(), bl.length());
+
+  ASSERT_STREQ("i0ei-3ei7e", s.c_str());
 }
 
 TEST(Bencode, Dict)
@@ -38,7 +42,9 @@ TEST(Bencode, Dict)
   decode.bencode("bar", "baz", bl);
   decode.bencode_end(bl);
 
-  ASSERT_STREQ("d3:fooi5e3:bar3:baze", bl.c_str());
+  string s(bl.c_str(), bl.length());
+
+  ASSERT_STREQ("d3:fooi5e3:bar3:baze", s.c_str());
 }
 
 TEST(Bencode, List)
@@ -51,5 +57,7 @@ TEST(Bencode, List)
   decode.bencode("bar", "baz", bl);
   decode.bencode_end(bl);
 
-  ASSERT_STREQ("l3:fooi5e3:bar3:baze", bl.c_str());
+  string s(bl.c_str(), bl.length());
+
+  ASSERT_STREQ("l3:fooi5e3:bar3:baze", s.c_str());
 }