From: Zack Cerza <zack@cerza.org>
Date: Wed, 25 Jul 2018 22:18:36 +0000 (-0600)
Subject: Revert "[DNM] upgrade check: upgrade to same version is a noop"
X-Git-Tag: 1.1.0~326^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F1195%2Fhead;p=teuthology.git

Revert "[DNM] upgrade check: upgrade to same version is a noop"
---

diff --git a/teuthology/task/install/__init__.py b/teuthology/task/install/__init__.py
index 9218329db..458b2c2b8 100644
--- a/teuthology/task/install/__init__.py
+++ b/teuthology/task/install/__init__.py
@@ -339,11 +339,6 @@ def upgrade_remote_to_config(ctx, config):
 
     return result
 
-def _upgrade_is_noop(installed_version, upgrade_version):
-    assert installed_version, "installed_version is empty"
-    assert upgrade_version, "upgrade_version is empty"
-    return LooseVersion(installed_version) == LooseVersion(upgrade_version)
-
 def _upgrade_is_downgrade(installed_version, upgrade_version):
     assert installed_version, "installed_version is empty"
     assert upgrade_version, "upgrade_version is empty"
@@ -377,11 +372,6 @@ def upgrade_common(ctx, config, deploy_style):
             i=installed_version,
             u=upgrade_version
         ))
-	if _upgrade_is_noop(installed_version, upgrade_version):
-            raise RuntimeError(
-                "Upgrade to the same version as is already installed is a "
-                " NOOP. Hint: check the test yaml."
-            )
 	if _upgrade_is_downgrade(installed_version, upgrade_version):
             raise RuntimeError(
                 "An attempt to upgrade from a higher version to a lower one "