From: zy751713126 <zhengyin@chinac.com>
Date: Tue, 25 Apr 2017 02:52:12 +0000 (+0800)
Subject: rbd/bench: add notes of default values, it's more easy to use
X-Git-Tag: v12.0.3~264^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F14762%2Fhead;p=ceph.git

rbd/bench: add notes of default values, it's more easy to use

Signed-off-by: Zheng Yin <zhengyin@chinac.com>
---

diff --git a/src/test/cli/rbd/help.t b/src/test/cli/rbd/help.t
index 8d4d5f59c3c4..b775c37ab896 100644
--- a/src/test/cli/rbd/help.t
+++ b/src/test/cli/rbd/help.t
@@ -121,10 +121,10 @@
   Optional arguments
     -p [ --pool ] arg    pool name
     --image arg          image name
-    --io-size arg        IO size (in B/K/M/G/T)
-    --io-threads arg     ios in flight
-    --io-total arg       total size for IO (in B/K/M/G/T)
-    --io-pattern arg     IO pattern (rand or seq)
+    --io-size arg        IO size (in B/K/M/G/T) [default: 4K]
+    --io-threads arg     ios in flight [default: 16]
+    --io-total arg       total size for IO (in B/K/M/G/T) [default: 1G]
+    --io-pattern arg     IO pattern (rand or seq) [default: seq]
     --io-type arg        IO type (read or write)
   
   rbd help children
diff --git a/src/tools/rbd/action/Bench.cc b/src/tools/rbd/action/Bench.cc
index f40c899fd489..d985922a7b19 100644
--- a/src/tools/rbd/action/Bench.cc
+++ b/src/tools/rbd/action/Bench.cc
@@ -314,10 +314,10 @@ void add_bench_common_options(po::options_description *positional,
   at::add_image_spec_options(positional, options, at::ARGUMENT_MODIFIER_NONE);
 
   options->add_options()
-    ("io-size", po::value<Size>(), "IO size (in B/K/M/G/T)")
-    ("io-threads", po::value<uint32_t>(), "ios in flight")
-    ("io-total", po::value<Size>(), "total size for IO (in B/K/M/G/T)")
-    ("io-pattern", po::value<IOPattern>(), "IO pattern (rand or seq)");
+    ("io-size", po::value<Size>(), "IO size (in B/K/M/G/T) [default: 4K]")
+    ("io-threads", po::value<uint32_t>(), "ios in flight [default: 16]")
+    ("io-total", po::value<Size>(), "total size for IO (in B/K/M/G/T) [default: 1G]")
+    ("io-pattern", po::value<IOPattern>(), "IO pattern (rand or seq) [default: seq]");
 }
 
 void get_arguments_for_write(po::options_description *positional,