From: Kefu Chai <kchai@redhat.com>
Date: Fri, 28 Apr 2017 06:13:53 +0000 (+0800)
Subject: common/hobject: use string::append() to avoid temp object
X-Git-Tag: v12.0.3~175^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F14863%2Fhead;p=ceph.git

common/hobject: use string::append() to avoid temp object

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/common/hobject.cc b/src/common/hobject.cc
index a965c87d6224..dffd471b7f95 100644
--- a/src/common/hobject.cc
+++ b/src/common/hobject.cc
@@ -75,7 +75,7 @@ string hobject_t::to_str() const
 
   char snap_with_hash[1000];
   char *t = snap_with_hash;
-  char *end = t + sizeof(snap_with_hash);
+  const char *end = t + sizeof(snap_with_hash);
 
   uint64_t poolid(pool);
   t += snprintf(t, end - t, "%.*llX", 16, (long long unsigned)poolid);
@@ -90,7 +90,7 @@ string hobject_t::to_str() const
   else
     t += snprintf(t, end - t, ".%llx", (long long unsigned)snap);
 
-  out += string(snap_with_hash);
+  out.append(snap_with_hash, t);
 
   out.push_back('.');
   append_escaped(oid.name, &out);