From: Jos Collin <jcollin@redhat.com>
Date: Sat, 24 Jun 2017 14:56:51 +0000 (+0530)
Subject: mon: Division by zero in PGMapDigest::dump_pool_stats_full()
X-Git-Tag: v12.1.2~1^2~59^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F15901%2Fhead;p=ceph.git

mon: Division by zero in PGMapDigest::dump_pool_stats_full()

Fixes The Coverity Scan Report:
CID 1412577 (#1 of 1): Division or modulo by float zero (DIVIDE_BY_ZERO)
35. divide_by_zero: In expression (float)mk / k, division by expression k which may be zero has undefined behavior.

Signed-off-by: Jos Collin <jcollin@redhat.com>
---

diff --git a/src/mon/PGMap.cc b/src/mon/PGMap.cc
index 91e06fb99e6c..1ab34f253cb4 100644
--- a/src/mon/PGMap.cc
+++ b/src/mon/PGMap.cc
@@ -683,6 +683,7 @@ void PGMapDigest::dump_pool_stats_full(
 	int mk = m + k;
 	assert(mk != 0);
 	avail = avail * k / mk;
+	assert(k != 0);
 	raw_used_rate = (float)mk / k;
       } else {
 	raw_used_rate = 0.0;