From: Kefu Chai <kchai@redhat.com>
Date: Thu, 6 Jul 2017 06:07:06 +0000 (+0800)
Subject: Revert "os/filestore: move ondisk in front, so that return oncommit earlier, and... 
X-Git-Tag: v12.1.1~172^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F16156%2Fhead;p=ceph.git

Revert "os/filestore: move ondisk in front, so that return oncommit earlier, and improve write op performance."

This reverts commit 21f167cf39cc7c025004e9b455ce8ba1252863f0.

Fixes: http://tracker.ceph.com/issues/20524
Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/os/filestore/FileStore.cc b/src/os/filestore/FileStore.cc
index 1d018f3eaf8a..b6b809aff9c3 100644
--- a/src/os/filestore/FileStore.cc
+++ b/src/os/filestore/FileStore.cc
@@ -2270,19 +2270,18 @@ void FileStore::_journaled_ahead(OpSequencer *osr, Op *o, Context *ondisk)
 
   o->trace.event("writeahead journal finished");
 
-  // do ondisk completions async, to prevent any onreadable_sync completions
-  // getting blocked behind an ondisk completion.
-  if (ondisk) {
-    dout(10) << " queueing ondisk " << ondisk << dendl;
-    ondisk_finishers[osr->id % m_ondisk_finisher_num]->queue(ondisk);
-  }
-
   // this should queue in order because the journal does it's completions in order.
   queue_op(osr, o);
 
   list<Context*> to_queue;
   osr->dequeue_journal(&to_queue);
 
+  // do ondisk completions async, to prevent any onreadable_sync completions
+  // getting blocked behind an ondisk completion.
+  if (ondisk) {
+    dout(10) << " queueing ondisk " << ondisk << dendl;
+    ondisk_finishers[osr->id % m_ondisk_finisher_num]->queue(ondisk);
+  }
   if (!to_queue.empty()) {
     ondisk_finishers[osr->id % m_ondisk_finisher_num]->queue(to_queue);
   }