From: amitkuma <amitkuma@redhat.com>
Date: Thu, 24 Aug 2017 18:02:46 +0000 (+0530)
Subject: test: Check to avoid divide by zero
X-Git-Tag: v13.0.1~1129^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F17220%2Fhead;p=ceph.git

test: Check to avoid divide by zero

Fixes the coverity issue:

** 1219467 Division or modulo by zero
CID 1219467 (#1 of 1): Division or modulo by zero (DIVIDE_BY_ZERO)
74. divide_by_zero: In expression 100 / atoi(args[i + 1U]), division
 by expression atoi(args[i + 1U]) which may be zero has undefined behavior.

Signed-off-by: Amit Kumar amitkuma@redhat.com
---

diff --git a/src/test/kv_store_bench.cc b/src/test/kv_store_bench.cc
index 3cdc7cfe01a7..b36a088dfd6e 100644
--- a/src/test/kv_store_bench.cc
+++ b/src/test/kv_store_bench.cc
@@ -115,7 +115,9 @@ int KvStoreBench::setup(int argc, const char** argv) {
       } else if (strcmp(args[i], "--cache-size") == 0) {
 	cache_size = atoi(args[i+1]);
       } else if (strcmp(args[i], "--cache-refresh") == 0) {
-	cache_refresh = 100 / atoi(args[i+1]);
+	auto temp = atoi(args[i+1]);
+	assert (temp != 0);
+	cache_refresh = 100 / temp;
       } else if (strcmp(args[i], "-t") == 0) {
 	max_ops_in_flight = atoi(args[i+1]);
       } else if (strcmp(args[i], "--clients") == 0) {