From: Kefu Chai <kchai@redhat.com>
Date: Mon, 28 Aug 2017 09:09:15 +0000 (+0800)
Subject: rgw: silence clang analyzer warning
X-Git-Tag: v13.0.1~1111^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F17294%2Fhead;p=ceph.git

rgw: silence clang analyzer warning

silences following warning:

Value stored to 'versioned_dest' is never read

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/rgw/rgw_rados.cc b/src/rgw/rgw_rados.cc
index 7d6732306bc..846da29d407 100644
--- a/src/rgw/rgw_rados.cc
+++ b/src/rgw/rgw_rados.cc
@@ -8098,12 +8098,9 @@ int RGWRados::copy_obj(RGWObjectCtx& obj_ctx,
     return ret;
   }
 
-  bool versioned_dest = dest_bucket_info.versioning_enabled();
-
   if (version_id && !version_id->empty()) {
-    versioned_dest = true;
     dest_obj.key.set_instance(*version_id);
-  } else if (versioned_dest) {
+  } else if (dest_bucket_info.versioning_enabled()) {
     gen_rand_obj_instance_name(&dest_obj);
   }