From: Dan Mick <dmick@redhat.com>
Date: Mon, 14 Nov 2022 20:17:21 +0000 (-0800)
Subject: provision/fog.py: log exceptions while looping for ssh
X-Git-Tag: 1.2.0~136^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F1795%2Fhead;p=teuthology.git

provision/fog.py: log exceptions while looping for ssh

Make sure the user knows of potential configuration problems, etc.

Fixes: https://tracker.ceph.com/issues/58015
Signed-off-by: Dan Mick <dmick@redhat.com>
---

diff --git a/teuthology/provision/fog.py b/teuthology/provision/fog.py
index 7427de420..440ca2c27 100644
--- a/teuthology/provision/fog.py
+++ b/teuthology/provision/fog.py
@@ -278,7 +278,12 @@ class FOG(object):
                     NoValidConnectionsError,
                     MaxWhileTries,
                     EOFError,
-                ):
+                ) as e:
+                    # log this, because otherwise lots of failures just
+                    # keep retrying without any notification (like, say,
+                    # a mismatched host key in ~/.ssh/known_hosts, or
+                    # something)
+                    log.warning(e)
                     pass
         sentinel_file = config.fog.get('sentinel_file', None)
         if sentinel_file: