From: Greg Farnum <gfarnum@redhat.com>
Date: Mon, 9 Oct 2017 21:16:05 +0000 (-0700)
Subject: common: by default, do not assert on leaks in the shared_cache code
X-Git-Tag: v13.0.1~610^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F18201%2Fhead;p=ceph.git

common: by default, do not assert on leaks in the shared_cache code

Update the standard qa suite cluster configs so that we continue
asserting in our nightlies, but users don't hit this.

Fixes: http://tracker.ceph.com/issues/21737

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
---

diff --git a/src/common/options.cc b/src/common/options.cc
index 5b8a4da68172..8d975c5d7914 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -4222,6 +4222,10 @@ std::vector<Option> get_global_options() {
     Option("debug_deliberately_leak_memory", Option::TYPE_BOOL, Option::LEVEL_DEV)
     .set_default(false)
     .set_description(""),
+      
+    Option("debug_asserts_on_shutdown", Option::TYPE_BOOL,Option::LEVEL_DEV)
+    .set_default(false)
+    .set_description("Enable certain asserts to check for refcounting bugs on shutdown; see http://tracker.ceph.com/issues/21738"),
   });
 }
 
diff --git a/src/common/shared_cache.hpp b/src/common/shared_cache.hpp
index 3332bd4f00ac..8d923eefc4de 100644
--- a/src/common/shared_cache.hpp
+++ b/src/common/shared_cache.hpp
@@ -105,7 +105,9 @@ public:
       lderr(cct) << "leaked refs:\n";
       dump_weak_refs(*_dout);
       *_dout << dendl;
-      assert(weak_refs.empty());
+      if (cct->_conf->get_val<bool>("debug_asserts_on_shutdown")) {
+	assert(weak_refs.empty());
+      }
     }
   }