From: Zack Cerza Date: Fri, 26 Jan 2024 21:02:09 +0000 (-0700) Subject: supervisor: Do not nuke nodes after jobs finish X-Git-Tag: 1.2.0~57^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F1913%2Fhead;p=teuthology.git supervisor: Do not nuke nodes after jobs finish This was causing a bad race condition, where we could unlock a node, then unlock it again via the nuke process after a different job had locked it. Fixes: https://tracker.ceph.com/issues/64193 Signed-off-by: Zack Cerza --- diff --git a/teuthology/dispatcher/supervisor.py b/teuthology/dispatcher/supervisor.py index 6af6f554a..bb3885d74 100644 --- a/teuthology/dispatcher/supervisor.py +++ b/teuthology/dispatcher/supervisor.py @@ -282,10 +282,6 @@ def unlock_targets(job_config): machine, job_info['owner'], job_info['archive_path'] ) - if job_status != 'pass' and job_config.get('nuke-on-error', False): - log.info('Nuking machines...') - fake_ctx = create_fake_context(job_config) - nuke.nuke(fake_ctx, True) def run_with_watchdog(process, job_config):