From: Patrick Donnelly <pdonnell@redhat.com>
Date: Mon, 27 Nov 2017 18:45:31 +0000 (-0800)
Subject: client: give full error message on failed remount
X-Git-Tag: v13.0.1~57^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F19181%2Fhead;p=ceph.git

client: give full error message on failed remount

Fixes: http://tracker.ceph.com/issues/22254

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
---

diff --git a/src/client/Client.cc b/src/client/Client.cc
index ddd517aa4b6..e5d3ae3a0fa 100644
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -18,6 +18,7 @@
 #include <sys/types.h>
 #include <time.h>
 #include <utime.h>
+#include <string.h>
 #include <sys/stat.h>
 #include <sys/param.h>
 #include <fcntl.h>
@@ -4020,12 +4021,14 @@ private:
 public:
   explicit C_Client_Remount(Client *c) : client(c) {}
   void finish(int r) override {
-    assert (r == 0);
+    assert(r == 0);
+    errno = 0;
     r = client->remount_cb(client->callback_handle);
     if (r != 0) {
+      int e = errno;
       client_t whoami = client->get_nodeid();
       lderr(client->cct) << "tried to remount (to trim kernel dentries) and got error "
-			 << r << dendl;
+			 << r << " (errno = " << e << "; " << strerror(e) << ")" << dendl;
       if (client->require_remount && !client->unmounting) {
 	assert(0 == "failed to remount for kernel dentry trimming");
       }