From: Boris Ranto Date: Thu, 7 Dec 2017 23:21:38 +0000 (+0100) Subject: librbd: Do not instantiate TrimRequest template class X-Git-Tag: v13.0.2~816^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F19402%2Fhead;p=ceph.git librbd: Do not instantiate TrimRequest template class We include TrimRequest.cc in librbd tests at two places: - operation/test_mock_TrimRequest.cc - operation/test_mock_ResizeRequest.cc That causes linking errors when doing the builds because some of the instantiated classes are defined twice. We can fix this by not instantiating the template class in the TrimReqeust.cc file when including it in the tests. Signed-off-by: Boris Ranto --- diff --git a/src/test/librbd/operation/test_mock_ResizeRequest.cc b/src/test/librbd/operation/test_mock_ResizeRequest.cc index e67f8a2a8321..7b70a50e8f48 100644 --- a/src/test/librbd/operation/test_mock_ResizeRequest.cc +++ b/src/test/librbd/operation/test_mock_ResizeRequest.cc @@ -44,7 +44,6 @@ TrimRequest *TrimRequest::s_instance = nullptr; // template definitions #include "librbd/operation/ResizeRequest.cc" -#include "librbd/operation/TrimRequest.cc" namespace librbd { namespace operation {