From: Gu Zhongyan <guzhongyan@360.cn>
Date: Wed, 11 Apr 2018 04:26:35 +0000 (+0800)
Subject: osd: drop unused osd_disk_tp related options
X-Git-Tag: v13.1.0~63^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F21339%2Fhead;p=ceph.git

osd: drop unused osd_disk_tp related options

disk_tp has been killed. So those are unused.

Signed-off-by: Gu Zhongyan <guzhongyan@360.cn>
---

diff --git a/src/common/options.cc b/src/common/options.cc
index fb6914d0dda6..bfdbe46ca5a7 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -2275,10 +2275,6 @@ std::vector<Option> get_global_options() {
     .set_default(65536)
     .set_description(""),
 
-    Option("osd_disk_threads", Option::TYPE_INT, Option::LEVEL_ADVANCED)
-    .set_default(1)
-    .set_description(""),
-
     Option("osd_recover_clone_overlap", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
     .set_default(true)
     .set_description(""),
diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc
index f86b3c25f60e..adced6ae8373 100644
--- a/src/osd/OSD.cc
+++ b/src/osd/OSD.cc
@@ -51,7 +51,6 @@
 #include "common/ceph_argparse.h"
 #include "common/ceph_time.h"
 #include "common/version.h"
-#include "common/io_priority.h"
 #include "common/pick_address.h"
 #include "common/SubProcess.h"
 #include "common/PluginRegistry.h"
@@ -8960,8 +8959,6 @@ const char** OSD::get_tracked_conf_keys() const
     "osd_map_cache_size",
     "osd_pg_epoch_max_lag_factor",
     "osd_pg_epoch_persisted_max_stale",
-    "osd_disk_thread_ioprio_class",
-    "osd_disk_thread_ioprio_priority",
     // clog & admin clog
     "clog_to_monitors",
     "clog_to_syslog",
diff --git a/src/test/test_workqueue.cc b/src/test/test_workqueue.cc
index 8bf6562f4ffe..f43e267bd605 100644
--- a/src/test/test_workqueue.cc
+++ b/src/test/test_workqueue.cc
@@ -18,34 +18,34 @@ TEST(WorkQueue, StartStop)
 
 TEST(WorkQueue, Resize)
 {
-  ThreadPool tp(g_ceph_context, "bar", "tp_bar", 2, "osd_disk_threads");
+  ThreadPool tp(g_ceph_context, "bar", "tp_bar", 2, "filestore_op_threads");
   
   tp.start();
 
   sleep(1);
   ASSERT_EQ(2, tp.get_num_threads());
 
-  g_conf->set_val("osd disk threads", "5");
+  g_conf->set_val("filestore op threads", "5");
   g_conf->apply_changes(&cout);
   sleep(1);
   ASSERT_EQ(5, tp.get_num_threads());
 
-  g_conf->set_val("osd disk threads", "3");
+  g_conf->set_val("filestore op threads", "3");
   g_conf->apply_changes(&cout);
   sleep(1);
   ASSERT_EQ(3, tp.get_num_threads());
 
-  g_conf->set_val("osd disk threads", "0");
+  g_conf->set_val("filestore op threads", "0");
   g_conf->apply_changes(&cout);
   sleep(1);
   ASSERT_EQ(0, tp.get_num_threads());
 
-  g_conf->set_val("osd disk threads", "15");
+  g_conf->set_val("filestore op threads", "15");
   g_conf->apply_changes(&cout);
   sleep(1);
   ASSERT_EQ(15, tp.get_num_threads());
 
-  g_conf->set_val("osd disk threads", "-1");
+  g_conf->set_val("filestore op threads", "-1");
   g_conf->apply_changes(&cout);
   sleep(1);
   ASSERT_EQ(15, tp.get_num_threads());