From: Dan Mick <dmick@redhat.com>
Date: Sat, 15 Jul 2023 01:09:08 +0000 (-0700)
Subject: library/jenkins_node: improve diagnostics on failure.
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F2147%2Fhead;p=ceph-build.git

library/jenkins_node: improve diagnostics on failure.

Capture exception args for exceptions that have no msg or message,
and capture a traceback.

Signed-off-by: Dan Mick <dmick@redhat.com>
---

diff --git a/ansible/library/jenkins_node b/ansible/library/jenkins_node
index 792a027c..e20c9d2c 100644
--- a/ansible/library/jenkins_node
+++ b/ansible/library/jenkins_node
@@ -101,6 +101,7 @@ EXAMPLES = """
            name={{ node_name }} operation=delete
 """
 import ast
+import traceback
 import xmltodict
 
 HAS_JENKINS_API = True
@@ -299,7 +300,9 @@ def main():
         else:
             message = getattr(ex, 'message', None)
             msg = getattr(ex, 'msg', message)
-            msg = "%s: %s" % (ex.__class__.__name__, msg)
+            if not msg:
+                msg = str(ex)
+            msg = "%s: %s\n%s" % (ex.__class__.__name__, msg, traceback.format_tb(ex.__traceback__))
         return module.fail_json(msg=msg)
 
     args = {'changed': changed}