From: Patrick Donnelly Date: Tue, 17 Apr 2018 13:39:09 +0000 (-0700) Subject: client: fix error operator precedence X-Git-Tag: v12.2.6~67^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F21495%2Fhead;p=ceph.git client: fix error operator precedence /home/pdonnell/ceph/src/client/Client.cc: In member function ‘int Client::mount(const string&, const UserPerm&, bool)’: /home/pdonnell/ceph/src/client/Client.cc:5681:23: warning: suggest parentheses around ‘+’ inside ‘<<’ [-Wparentheses] return CEPH_FUSE_NO_MDS_UP; ~~^~ Found by gcc. I am ashamed. Signed-off-by: Patrick Donnelly (cherry picked from commit 75f980d85256e22b7b79e5f64bfa3fc6018328b5) --- diff --git a/src/client/Client.h b/src/client/Client.h index d5f40b18b22f..75728189878e 100644 --- a/src/client/Client.h +++ b/src/client/Client.h @@ -94,8 +94,8 @@ class MDSCommandOp : public CommandOp }; /* error code for ceph_fuse */ -#define CEPH_FUSE_NO_MDS_UP -(1<<16+0) /* no mds up deteced in ceph_fuse */ -#define CEPH_FUSE_LAST -(1<<16+1) /* (unused) */ +#define CEPH_FUSE_NO_MDS_UP -((1<<16)+0) /* no mds up deteced in ceph_fuse */ +#define CEPH_FUSE_LAST -((1<<16)+1) /* (unused) */ // ============================================ // types for my local metadata cache