From: Tiago Melo <tmelo@suse.com>
Date: Wed, 20 Jun 2018 09:25:24 +0000 (+0100)
Subject: mgr/dashboard: Update node version
X-Git-Tag: v14.0.1~1053^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F22639%2Fhead;p=ceph.git

mgr/dashboard: Update node version

Updated node version to the latest LTS.

Updated 'HACKING.rst' to reflect the current node/npm version requirements.

Signed-off-by: Tiago Melo <tmelo@suse.com>
---

diff --git a/src/pybind/mgr/dashboard/CMakeLists.txt b/src/pybind/mgr/dashboard/CMakeLists.txt
index 2b050f6c6e6f..d5d000dc8508 100644
--- a/src/pybind/mgr/dashboard/CMakeLists.txt
+++ b/src/pybind/mgr/dashboard/CMakeLists.txt
@@ -15,7 +15,7 @@ add_custom_command(
   OUTPUT "${mgr-dashboard-nodeenv}/bin/npm"
   COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh --python=${MGR_PYTHON_EXECUTABLE} ${mgr-dashboard-nodeenv}
   COMMAND ${mgr-dashboard-nodeenv}/bin/pip install nodeenv
-  COMMAND ${mgr-dashboard-nodeenv}/bin/nodeenv -p -n 8.10.0
+  COMMAND ${mgr-dashboard-nodeenv}/bin/nodeenv -p -n 8.11.3
   WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
   COMMENT "dashboard nodeenv is being installed"
 )
diff --git a/src/pybind/mgr/dashboard/HACKING.rst b/src/pybind/mgr/dashboard/HACKING.rst
index b82d9f6cea9b..46efba7407e4 100644
--- a/src/pybind/mgr/dashboard/HACKING.rst
+++ b/src/pybind/mgr/dashboard/HACKING.rst
@@ -15,8 +15,8 @@ The build process is based on `Node.js <https://nodejs.org/>`_ and requires the
 Prerequisites
 ~~~~~~~~~~~~~
 
- * Node 6.9.0 or higher
- * NPM 3 or higher
+ * Node 8.9.0 or higher
+ * NPM 5.5.1 or higher
 
 nodeenv:
   During Ceph's build we create a virtualenv with ``node`` and ``npm``