From: Mykola Golub <mgolub@suse.com>
Date: Sat, 18 Aug 2018 16:24:55 +0000 (+0300)
Subject: librbd: potential race on image create request complete
X-Git-Tag: v14.0.1~554^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F23639%2Fhead;p=ceph.git

librbd: potential race on image create request complete

Fixes: http://tracker.ceph.com/issues/24910
Signed-off-by: Mykola Golub <mgolub@suse.com>
---

diff --git a/src/librbd/image/CreateRequest.cc b/src/librbd/image/CreateRequest.cc
index 3dec768b05b..6d97dd46dff 100644
--- a/src/librbd/image/CreateRequest.cc
+++ b/src/librbd/image/CreateRequest.cc
@@ -737,8 +737,9 @@ void CreateRequest<I>::complete(int r) {
   }
 
   m_data_io_ctx.close();
-  m_on_finish->complete(r);
+  auto on_finish = m_on_finish;
   delete this;
+  on_finish->complete(r);
 }
 
 // cleanup